From 9e7bfc6e3a01b8b1eea09d71eeced9a29285e203 Mon Sep 17 00:00:00 2001
From: e3mrah <81884938+emrahbaysal@users.noreply.github.com>
Date: Fri, 1 May 2026 12:09:38 +0400
Subject: [PATCH] fix(catalyst-ui): live deployed-SHA Playwright fixes for #348
 P1 (#362)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Three deployed-SHA validation fixes uncovered by running the new e2e
suite against console.openova.io:

1. Drop the hidden legacy `infrastructure-detail-panel-neighbor-{id}`
   span in DetailPanel — having display:none on it broke the legacy
   test 4's `toBeVisible()` assertion. The legacy testid was not
   needed; the existing tests now key off the new
   `arch-detail-panel-neighbor-{relation}-{id}` ids.

2. Tighten the NodePool+PVC isolation test selector from
   `[data-testid^="arch-graph-node-"]` to `g[data-node-type]` — the
   broad prefix selector was matching the per-icon test ids
   (`arch-graph-node-icon-{type}`) which don't carry data-node-type
   and produced null `getAttribute()` reads.

3. Make the ArchiMate legend close-up screenshot resilient to a
   legend that's below the viewport: scrollIntoViewIfNeeded() and
   bound the clip box against the actual viewport size before
   passing to page.screenshot.

Co-authored-by: hatiyildiz <hati@openova.io>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>