openova/openova
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(pipeline-layout): index jobs by both id and jobName so dependsOn resolves (#244)

Browse Source 
Co-authored-by: hatiyildiz <hatice.yildiz@openova.io>
This commit is contained in:
e3mrah 2026-04-30 14:07:00 +04:00 committed by GitHub
parent 363346bfcd
commit 6746fdefd0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
products/catalyst/bootstrap/ui/src/lib/pipelineLayout.ts
View File

@ -545,8 +545,17 @@ export function pipelineLayout(
// 1. Group jobs by batch. Preserve discovery order so that, when
// the meta-DAG has no cross-batch edges, the meta-Sugiyama
// position tie-breaker (id ascending) yields a stable layout.
//
// Job.dependsOn is a list of jobNames ("install-cilium"), not full
// ids ("<deploymentId>:install-cilium"). The catalyst-api Bridge
// emits this form so dependsOn is operator-readable across the
// wire. We index BOTH forms here so the inner/meta edge lookup
// resolves a dep regardless of which form the source feed uses.
const jobById = new Map<string, Job>()
for (const j of jobs) jobById.set(j.id, j)
for (const j of jobs) {
jobById.set(j.id, j)
if (j.jobName && j.jobName !== j.id) jobById.set(j.jobName, j)
}
const batchIds: string[] = []
const jobsByBatch = new Map<string, Job[]>()
@ -610,7 +619,10 @@ export function pipelineLayout(
const depJob = jobById.get(dep)
if (!depJob) continue
if (depJob.batchId !== batchId) continue
inner.push({ from: dep, to: j.id })
// Always emit edges using the canonical Job.id form so the
// sugiyama() ids[] (built from j.id) and the relNodes lookup
// by-id later resolve consistently. dep may be the jobName.
inner.push({ from: depJob.id, to: j.id })
}
}
const innerSugi = sugiyama(ids, inner)