openova/openova
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(jobs): GetJob accepts bare jobName (Traefik mangles encoded colons)

Browse Source
This commit is contained in:
hatiyildiz 2026-04-30 09:28:34 +02:00
parent a076a369dd
commit 1c9e9666f4
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
products/catalyst/bootstrap/api/internal/jobs/store.go
View File

@ -478,18 +478,25 @@ func (s *Store) GetJob(deploymentID, jobID string) (Job, []Execution, error) {
if err != nil {
return Job{}, nil, err
}
// Lookup accepts EITHER the full "<deploymentId>:<jobName>" id OR
// the bare jobName. The colon in the canonical id is path-safe per
// RFC 3986 §3.3 but Traefik (or some upstream proxy) was observed
// returning 404 on URL-encoded colons in the path segment, so the
// FE may send the bare jobName. (depID, jobName) is unique per
// deployment, so the bare-name lookup is always unambiguous.
for i := range idx.Jobs {
if idx.Jobs[i].ID == jobID {
j := idx.Jobs[i]
if j.ID == jobID || j.JobName == jobID {
execs := []Execution{}
for _, e := range idx.Executions {
if e.JobID == jobID {
if e.JobID == j.ID {
execs = append(execs, e)
}
}
sort.Slice(execs, func(a, b int) bool {
return execs[a].StartedAt.After(execs[b].StartedAt)
})
return idx.Jobs[i], execs, nil
return j, execs, nil
}
}
return Job{}, nil, fmt.Errorf("jobs: GetJob %q: %w", jobID, ErrNotFound)